Issue 2084001: Reduce the size of factory install shim.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2084001: Reduce the size of factory install shim. (Closed)

Created:
10 years, 7 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders, girts

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromiumos

Visibility:
Public.

Description

Reduce the size of factory install shim. Temporary approach to using INSTALL_MASK to suppress some non-relevant paths. It reduces the size from ~426MB to ~163MB. Eventually, will remove it and create a clean and separated ebuild for chromeos-factoryinstall.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Patch Set 3 : move flag to common.sh #

Patch Set 4 : algin #

Patch Set 5 : down to 180mb #

Patch Set 6 : merge and cleanup #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -7 lines)			Patch
	M	src/scripts/build_image	View	1 2 3 4 5	5 chunks	+23 lines, -7 lines	0 comments	Download
	M	src/scripts/common.sh	View	3 4	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

lgtm Nice, clean way to shrink the image! http://codereview.chromium.org/2084001/diff/1/2 File src/scripts/build_image (right): http://codereview.chromium.org/2084001/diff/1/2#newcode45 src/scripts/build_image:45: "Whether ...

10 years, 7 months ago (2010-05-14 06:25:27 UTC) #2

Expand Messages | Collapse Messages