Issue 2083012: enable RenderViewTest.OnHandleKeyboardEvent on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2083012: enable RenderViewTest.OnHandleKeyboardEvent on Linux. (Closed)

Created:
10 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

enable RenderViewTest.OnHandleKeyboardEvent on Linux. Rearrange some existing automation code and write some new code. BUG=none TEST=runs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47624

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+222 lines, -107 lines)			Patch
M	base/base.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/event_synthesis_gtk.h	View	1 chunk	+36 lines, -0 lines	1 comment	Download
A	base/event_synthesis_gtk.cc	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_linux.cc	View	3 chunks	+10 lines, -68 lines	0 comments	Download
M	chrome/renderer/render_view_unittest.cc	View	6 chunks	+47 lines, -39 lines	0 comments	Download
M	chrome/test/render_view_test.cc	View	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

LGTM with a nit. Thank you for implementing this test for Linux. Regards, Hironori Bono ...

10 years, 7 months ago (2010-05-19 03:25:13 UTC) #2

Hironori Bono

10 years, 7 months ago (2010-05-19 10:53:32 UTC) #3

Greetings,

It seems this test fails on the "Linux Tests (valgrind)(1)" bot. I have filed
Issue 44552 <http://crbug.com/44552> and temporarily disabled this test on
valgrind.

(*1)
<http://chrome-buildbot.corp.google.com:8014/builders/Linux%20Tests%20(valgrin...>

Regards,

Hironori Bono

Expand Messages | Collapse Messages