src/platform/vboot_reference/cgptlib/Makefile - Issue 2082015: add cgpt framework and attribute support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/platform/vboot_reference/cgptlib/Makefile

Issue 2082015: add cgpt framework and attribute support. (Closed) Base URL: ssh://git@chromiumos-git/chromeos

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« src/platform/vboot_reference/Makefile ('K') | « src/platform/vboot_reference/Makefile ('k') | src/platform/vboot_reference/cgptlib/cgptlib.h » ('j') | src/platform/vboot_reference/utility/Makefile » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.	1 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 CFLAGS += -Wall -Werror -ansi	5 CFLAGS += -Wall -Werror -ansi

6 INCLUDES += -Itests	6 INCLUDES += -Itests

7 SUBDIRS = tests	7 SUBDIRS = tests

8	8

9 all: cgpt.a	9 all: libcgpt.a

	10 » set -e; \

10 for i in $(SUBDIRS); do \	11 for i in $(SUBDIRS); do \

11 » ( cd $$i ; $(MAKE)) ; \	12 » » $(MAKE) -C $$i; \
	Bill Richardson 2010/05/20 16:51:15 That's not parallelizable. Use this instead: all: That's not parallelizable. Use this instead: all: libcgpt.a $(foreach DIR,$(SUBDIRS),$(DIR)-subdir) %-subdir : $(MAKE) -C $(subst -subdir,,$@) $(MAKECMDGOALS) Louis 2010/05/21 03:43:21 This cannot be parallelized because we need libcgp Show quoted text On 2010/05/20 16:51:15, Bill Richardson wrote: > That's not parallelizable. Use this instead: > > all: libcgpt.a $(foreach DIR,$(SUBDIRS),$(DIR)-subdir) > > %-subdir : > $(MAKE) -C $(subst -subdir,,$@) $(MAKECMDGOALS) > This cannot be parallelized because we need libcgpt.a be ready before compiling subdirs.
12 done	13 done

13	14

14 .c.o:	15 .c.o:

15 $(CC) $(CFLAGS) $(INCLUDES) -c $< -o $@	16 $(CC) $(CFLAGS) $(INCLUDES) -c $< -o $@

16	17

17 cgpt.a: cgptlib.o quick_sort.o crc32.o	18 libcgpt.a: cgptlib.o quick_sort.o crc32.o

18 $(AR) rs $@ $^	19 $(AR) rs $@ $^

19	20

20 clean:	21 clean:

	22 set -e; \

21 for i in $(SUBDIRS); do \	23 for i in $(SUBDIRS); do \
	Bill Richardson 2010/05/20 16:51:15 clean: $(foreach DIR,$(SUBDIRS),$(DIR)-subdir) clean: $(foreach DIR,$(SUBDIRS),$(DIR)-subdir) Louis 2010/05/21 03:43:21 This cannot be parallelized because our build syst Show quoted text On 2010/05/20 16:51:15, Bill Richardson wrote: > clean: $(foreach DIR,$(SUBDIRS),$(DIR)-subdir) This cannot be parallelized because our build system uses "make clean all" and accidentally triggers 'make all' in '%-subdir:'.
22 » ( $(MAKE) -C $$i clean ) ; \	24 » » $(MAKE) -C $$i clean; \

23 done	25 done

24 rm -f .o ~ *.a	26 rm -f .o ~ *.a

OLD	NEW