Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2082011: [Mac] Add a preference for the tab key cycling between just form fields, or links as well. (Closed)

Created:
10 years, 7 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[Mac] Add a preference for the tab key cycling between just form fields, or links as well. XIB change: Add a checkbox bound to FilesOwner.tabsToLinks underneath the translate webpages preference. BUG=31177 TEST=Uncheck Chromium-->Preferences-->Under the Hood-->Pressing Tab... Then press Tab on Google.com and the links don't get focus; it alternates between search field and location bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47807

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re-save XIB on 10.5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -86 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/nibs/Preferences.xib View 1 63 chunks +145 lines, -86 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/options_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
10 years, 7 months ago (2010-05-19 00:18:30 UTC) #1
pink (ping after 24hrs)
code lgtm, nib change worries me a bit. http://codereview.chromium.org/2082011/diff/1/3 File chrome/app/nibs/Preferences.xib (right): http://codereview.chromium.org/2082011/diff/1/3#newcode5 chrome/app/nibs/Preferences.xib:5: <string ...
10 years, 7 months ago (2010-05-19 15:25:33 UTC) #2
Robert Sesek
Pink: I (well, Mark) re-saved the XIB on 10.5.
10 years, 7 months ago (2010-05-19 19:02:51 UTC) #3
pink (ping after 24hrs)
10 years, 7 months ago (2010-05-19 21:08:31 UTC) #4
lgtlm

Powered by Google App Engine
This is Rietveld 408576698