Issue 2082007: rename cgpt files with cgptlib prefix (to avoid conflicts to cgpt utility)

Issue 2082007: rename cgpt files with cgptlib prefix (to avoid conflicts to cgpt utility) (Closed)

Created:
10 years, 7 months ago by Louis

Modified:
9 years, 4 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, gauravsh

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

rename cgpt files with cgptlib prefix (to avoid conflicts to cgpt utility)

Patch Set 1 #

Total comments: 6

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	src/platform/vboot_reference/Makefile	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/cgptlib/Makefile	View	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	src/platform/vboot_reference/cgptlib/cgptlib.h	View	0 chunks	+-1 lines, --1 lines	2 comments	Download
A +	src/platform/vboot_reference/cgptlib/cgptlib.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	src/platform/vboot_reference/cgptlib/cgptlib_internal.h	View	1 chunk	+1 line, -1 line	2 comments	Download
M	src/platform/vboot_reference/cgptlib/tests/Makefile	View	1 chunk	+3 lines, -4 lines	0 comments	Download
A +	src/platform/vboot_reference/cgptlib/tests/cgptlib_test.h	View	0 chunks	+-1 lines, --1 lines	2 comments	Download
A +	src/platform/vboot_reference/cgptlib/tests/cgptlib_test.c	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/platform/vboot_reference/cgptlib/tests/quick_sort_test.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

One comment, otherwise LGTM. http://codereview.chromium.org/2082007/diff/1/5 File src/platform/vboot_reference/cgptlib/cgptlib.h (right): http://codereview.chromium.org/2082007/diff/1/5#newcode7 src/platform/vboot_reference/cgptlib/cgptlib.h:7: #define VBOOT_REFERENCE_CGPT_H_ Change the #define ...

10 years, 7 months ago (2010-05-17 15:15:03 UTC) #2

Louis

10 years, 7 months ago (2010-05-18 08:18:02 UTC) #3

Thanks, bill. Submitted.

http://codereview.chromium.org/2082007/diff/1/5
File src/platform/vboot_reference/cgptlib/cgptlib.h (right):

http://codereview.chromium.org/2082007/diff/1/5#newcode7
src/platform/vboot_reference/cgptlib/cgptlib.h:7: #define
VBOOT_REFERENCE_CGPT_H_
On 2010/05/17 15:15:03, Bill Richardson wrote:
> Change the #define to match the new file name.

Done.

http://codereview.chromium.org/2082007/diff/1/6
File src/platform/vboot_reference/cgptlib/cgptlib_internal.h (right):

http://codereview.chromium.org/2082007/diff/1/6#newcode7
src/platform/vboot_reference/cgptlib/cgptlib_internal.h:7: #define
VBOOT_REFERENCE_CGPT_INTERNAL_H_
On 2010/05/17 15:15:03, Bill Richardson wrote:
> Change the #define to match the new file name.

Done.

http://codereview.chromium.org/2082007/diff/1/9
File src/platform/vboot_reference/cgptlib/tests/cgptlib_test.h (right):

http://codereview.chromium.org/2082007/diff/1/9#newcode6
src/platform/vboot_reference/cgptlib/tests/cgptlib_test.h:6: #define
VBOOT_REFERENCE_CGPT_TEST_H_
On 2010/05/17 15:15:03, Bill Richardson wrote:
> Should change the #define to match the new file name.

Done.

Expand Messages | Collapse Messages