fix for issue 2610:

fix for issue 2610:
 - add recovery installer config file (which invokes chromeos-install with
   --recovery flag)
 - update build_image to install recovery_installer pkg and changed base image
   name to recovery_image.bin

[adlr, 2010-05-24 14:30:06]

http://codereview.chromium.org/2081018/diff/5001/6001
File src/platform/init/chromeos_startup (right):

http://codereview.chromium.org/2081018/diff/5001/6001#newcode46
src/platform/init/chromeos_startup:46: # TODO(tgao): need special handling when
/root/.recovery_installer exists?
yeah, this is probably a good idea for you, too. use a tmpfs just like the
factory installer case

[Tan Gao, 2010-05-24 16:55:04]

http://codereview.chromium.org/2081018/diff/5001/6001
File src/platform/init/chromeos_startup (right):

http://codereview.chromium.org/2081018/diff/5001/6001#newcode46
src/platform/init/chromeos_startup:46: # TODO(tgao): need special handling when
/root/.recovery_installer exists?
Done.

[Tan Gao, 2010-05-28 23:20:51]

Hi Andrew,

I finally got the USB image to install automatically (only if booted from a
recovery USB image, of course :-) What a nice breakthrough just before the long
weekend~

PTAL

Tan

[adlr, 2010-06-01 22:17:52]

http://codereview.chromium.org/2081018/diff/31001/30002
File src/platform/init/chromeos_startup (right):

http://codereview.chromium.org/2081018/diff/31001/30002#newcode28
src/platform/init/chromeos_startup:28: if [ ! -f /root/.factory_test ] && [ ! -f
/root/.factory_installer ] \
add && before \?

http://codereview.chromium.org/2081018/diff/31001/30004
File src/scripts/build_image (right):

http://codereview.chromium.org/2081018/diff/31001/30004#newcode198
src/scripts/build_image:198: trap "developer_cleanup \"$root_fs_dir\"
\"$stateful_dir\"" EXIT
can you avoid all code duplication and put common code in a function which is
called from both places?

[Tan Gao, 2010-06-02 22:09:55]

combined create_recovery_image and create_developer_image into a common method
create_mod_image

PTAL

http://codereview.chromium.org/2081018/diff/31001/30002
File src/platform/init/chromeos_startup (right):

http://codereview.chromium.org/2081018/diff/31001/30002#newcode28
src/platform/init/chromeos_startup:28: if [ ! -f /root/.factory_test ] && [ ! -f
/root/.factory_installer ] \
Done. good catch!

http://codereview.chromium.org/2081018/diff/31001/30004
File src/scripts/build_image (right):

http://codereview.chromium.org/2081018/diff/31001/30004#newcode198
src/scripts/build_image:198: trap "developer_cleanup \"$root_fs_dir\"
\"$stateful_dir\"" EXIT
refactored and renamed create_developer_image to create_mod_image to support
both developer image and recovery image

[adlr, 2010-06-02 22:16:41]

i don't see your updates to chromeos_startup...

http://codereview.chromium.org/2081018/diff/31001/30004
File src/scripts/build_image (right):

http://codereview.chromium.org/2081018/diff/31001/30004#newcode286
src/scripts/build_image:286: echo "Developer image built and stored at
$output_img"
keep this line in, at least for developer images?

http://codereview.chromium.org/2081018/diff/39001/40003#newcode195
src/scripts/build_image:195: local root_fs_dir="${OUTPUT_DIR}/rootfs_recovery"
mod_image sounds like either a boolean or a path to an image file. how about
calling it image_type?

[Tan Gao, 2010-06-02 22:32:12]

PTAL. thanks!

http://codereview.chromium.org/2081018/diff/31001/30004
File src/scripts/build_image (right):

http://codereview.chromium.org/2081018/diff/31001/30004#newcode286
src/scripts/build_image:286: echo "Developer image built and stored at
$output_img"
yup, this line is still in, exactly for developer image .. maybe you are looking
at an older snapshot of this file?

http://codereview.chromium.org/2081018/diff/39001/40003#newcode195
src/scripts/build_image:195: local root_fs_dir="${OUTPUT_DIR}/rootfs_recovery"
Done.

[adlr, 2010-06-02 22:34:12]

LGTM