Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/default_plugin/plugin_database_handler.cc

Issue 2081007: Enable warning 4389 as an error on windows builds. This will make... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/table/table_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/default_plugin/plugin_database_handler.cc
===================================================================
--- webkit/default_plugin/plugin_database_handler.cc (revision 48060)
+++ webkit/default_plugin/plugin_database_handler.cc (working copy)
@@ -144,13 +144,13 @@
}
}
- unsigned long bytes_written = 0;
+ DWORD bytes_written = 0;
if (0 == lstrcmpiA(stream->url, plugin_finder_url_.c_str())) {
DCHECK(plugin_downloads_file_ != INVALID_HANDLE_VALUE);
WriteFile(plugin_downloads_file_, buffer, buffer_length, &bytes_written,
NULL);
- DCHECK(buffer_length == bytes_written);
+ DCHECK_EQ(buffer_length, static_cast<int32>(bytes_written));
}
return bytes_written;
}
« no previous file with comments | « views/controls/table/table_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698