Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/browser/importer/importer_unittest.cc

Issue 2081007: Enable warning 4389 as an error on windows builds. This will make... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_uitest.cc ('k') | chrome/browser/sync/syncable/syncable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/importer_unittest.cc
===================================================================
--- chrome/browser/importer/importer_unittest.cc (revision 48060)
+++ chrome/browser/importer/importer_unittest.cc (working copy)
@@ -122,7 +122,7 @@
typedef struct {
const bool in_toolbar;
- const int path_size;
+ const size_t path_size;
const wchar_t* path[kMaxPathSize];
const wchar_t* title;
const char* url;
@@ -184,7 +184,7 @@
list[i].url == entry.url.spec() &&
list[i].title == entry.title) {
bool equal = true;
- for (int k = 0; k < list[i].path_size; ++k)
+ for (size_t k = 0; k < list[i].path_size; ++k)
if (list[i].path[k] != entry.path[k]) {
equal = false;
break;
« no previous file with comments | « chrome/browser/extensions/extension_uitest.cc ('k') | chrome/browser/sync/syncable/syncable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698