Enable warning 4389 as an error on windows builds. This will make...

chrome/browser/sync/syncable/syncable.cc

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/syncable/syncable.h"
 
 #include "build/build_config.h"
 
 #include <sys/stat.h>
 #if defined(OS_POSIX)
 #include <sys/time.h>
@@ skipping 567 matching lines @@
     MetahandlesIndex::iterator found =
         kernel_->metahandles_index->find(&kernel_->needle);
     EntryKernel* entry = (found == kernel_->metahandles_index->end() ?
                           NULL : *found);
     if (entry && SafeToPurgeFromMemory(entry)) {
       // We now drop deleted metahandles that are up to date on both the client
       // and the server.
       size_t num_erased = 0;
       kernel_->flushed_metahandles.Push(entry->ref(META_HANDLE));
       num_erased = kernel_->ids_index->erase(entry);
-      DCHECK(1 == num_erased);
+      DCHECK_EQ(1u, num_erased);
       num_erased = kernel_->metahandles_index->erase(entry);
-      DCHECK(1 == num_erased);
+      DCHECK_EQ(1u, num_erased);
 
-      num_erased = kernel_->client_tag_index->erase(entry);  // Might not be in it
-      DCHECK(!entry->ref(UNIQUE_CLIENT_TAG).empty() == num_erased);
+      // Might not be in it
+      num_erased = kernel_->client_tag_index->erase(entry);
+      DCHECK_EQ(entry->ref(UNIQUE_CLIENT_TAG).empty(), !num_erased);
       delete entry;
     }
   }
 
   ExtendedAttributes::const_iterator i = snapshot.dirty_xattrs.begin();
   while (i != snapshot.dirty_xattrs.end()) {
     ExtendedAttributeKey key(i->first.metahandle, i->first.key);
     ExtendedAttributes::iterator found =
         kernel_->extended_attributes->find(key);
     if (found == kernel_->extended_attributes->end() ||
@@ skipping 976 matching lines @@
   return s << std::dec;
 }
 
 FastDump& operator<<(FastDump& dump, const syncable::Blob& blob) {
   if (blob.empty())
     return dump;
   string buffer(HexEncode(&blob[0], blob.size()));
   dump.out_->sputn(buffer.c_str(), buffer.size());
   return dump;
 }