Issue 208062: Fix up aggregate dashboard to use the new data. The only thing missing now is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208062: Fix up aggregate dashboard to use the new data. The only thing missing now is... (Closed)

Created:
11 years, 3 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix up aggregate dashboard to use the new data. The only thing missing now is the number of skipped results on sharded builders. This has been true forever. I'll have a partial fix for that in a separate change. This time, the data format is really done and ready to be turned into pretty graphs. The data for each row in this table is created as an array, then getHTMLForTableRow is called. The graph version of this should be able to just rewrite getHTMLForTableRow to use canvas instead.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -28 lines)			Patch
	M	webkit/tools/layout_tests/dashboards/aggregate_results.html	View		1 chunk	+51 lines, -23 lines	0 comments	Download
	M	webkit/tools/layout_tests/dashboards/dashboard_base.js	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Did somebody say "pretty graphs"?!

LGTM.

Expand Messages | Collapse Messages