Issue 208051: Coverity: Initialize instance_id_ in the constructor....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208051: Coverity: Initialize instance_id_ in the constructor.... (Closed)

Created:
11 years, 3 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
jam, mattm

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Coverity: Initialize instance_id_ in the constructor. CID=6212 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26858

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/renderer/webplugin_delegate_proxy.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mattm

Not really familiar with this code, but is 0 okay, or should it be -1 ...

11 years, 3 months ago (2009-09-21 23:07:56 UTC) #2

jam

http://codereview.chromium.org/208051/diff/1/2 File chrome/renderer/webplugin_delegate_proxy.cc (right): http://codereview.chromium.org/208051/diff/1/2#newcode166 Line 166: instance_id_(0), since this is a routing id, it ...

11 years, 3 months ago (2009-09-21 23:17:59 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 208051: Coverity: Initialize instance_id_ in the constructor.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages