Issue 208037: Added command buffer unit tests to gyp....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208037: Added command buffer unit tests to gyp.... (Closed)

Created:
11 years, 3 months ago by apatrick

Modified:
9 years, 7 months ago

Reviewers:
rlp

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Added command buffer unit tests to gyp. Can optionally override default renderer with environment variable. One of: GYP_DEFINES = "renderer=d3d9" GYP_DEFINES = "renderer=gl" GYP_DEFINES = "renderer=cb cb_service=d3d9" GYP_DEFINES = "renderer=cb cb_service=gl" Fixed some warnings. Works on windows with D3D9 but not GL, mac or linux yet. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27125

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -102 lines)			Patch
M	DEPS	View		1 chunk	+91 lines, -52 lines	0 comments	Download
M	build/common.gypi	View	1	7 chunks	+49 lines, -6 lines	0 comments	Download
M	command_buffer/client/cross/cmd_buffer_helper_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	command_buffer/client/cross/id_allocator_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	command_buffer/command_buffer.gyp	View	1	6 chunks	+70 lines, -21 lines	0 comments	Download
M	command_buffer/service/cross/cmd_buffer_engine_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	command_buffer/service/cross/gl/effect_gl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/core.gyp	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	core/cross/gl/renderer_gl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	import/cross/precompile.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	import/import.gyp	View	1	3 chunks	+3 lines, -12 lines	0 comments	Download
M	plugin/plugin.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/common/win/testing_common.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/tests.gyp	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rlp

LGTM but not sure I see where the command buffers default to GL. Since it's ...

11 years, 3 months ago (2009-09-21 00:23:41 UTC) #2

apatrick

Next on my list is to add another GYP_DEFINES variable to select command buffer implementation. ...

11 years, 3 months ago (2009-09-21 18:04:17 UTC) #3

More changes...

Expand Messages | Collapse Messages