Issue 208030: Mac YUV assembly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208030: Mac YUV assembly (Closed)

Created:
11 years, 3 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, John Grabowski, pam+watch_chromium.org, awong, brettw, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mac YUV assembly BUG=20749 TEST=play mac video... it should be 3 times faster rendering and visibly smoother Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26614

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -273 lines)			Patch
	M	media/base/yuv_row.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	media/base/yuv_row_mac.cc	View		6 chunks	+61 lines, -270 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

11 years, 3 months ago (2009-09-18 20:59:57 UTC) #2

LGTM.

FYI, we've both attempted to repro the unittest failures that mhm reported for
the original checkin of this code and cannot do it.  It *looks* like it hsould
be safe, so we're going to try checking in again and if it fails, at least we'll
have more context for investigating why (the build results from the first
checkin have been lost in the stream of time...)

Expand Messages | Collapse Messages