Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 208021: Remove the intializaton of the Download Manager when bringing up (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the intializaton of the Download Manager when bringing up the options dialog. This was done a long long time ago because we used to register the download dir pref in the Download Manager constructor. Since that's no longer the case, we don't need to intialize the Download Manager.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/gtk/options/options_window_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/options/options_window_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 3 months ago (2009-09-18 00:49:03 UTC) #1
Lei Zhang
LGTM
11 years, 3 months ago (2009-09-18 02:24:29 UTC) #2
Paul Godavari
11 years, 3 months ago (2009-09-18 03:21:14 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698