Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/browser/views/toolbar_view.cc

Issue 208017: Lands http://codereview.chromium.org/203029 for Thiago:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/views/bookmark_menu_button.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/toolbar_view.h" 5 #include "chrome/browser/views/toolbar_view.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "app/drag_drop_types.h" 9 #include "app/drag_drop_types.h"
10 #include "app/gfx/canvas.h" 10 #include "app/gfx/canvas.h"
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
860 page_menu_->SetTooltipText(l10n_util::GetString(IDS_PAGEMENU_TOOLTIP)); 860 page_menu_->SetTooltipText(l10n_util::GetString(IDS_PAGEMENU_TOOLTIP));
861 page_menu_->SetID(VIEW_ID_PAGE_MENU); 861 page_menu_->SetID(VIEW_ID_PAGE_MENU);
862 862
863 863
864 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false); 864 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false);
865 app_menu_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_APP)); 865 app_menu_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_APP));
866 app_menu_->SetTooltipText(l10n_util::GetStringF(IDS_APPMENU_TOOLTIP, 866 app_menu_->SetTooltipText(l10n_util::GetStringF(IDS_APPMENU_TOOLTIP,
867 l10n_util::GetString(IDS_PRODUCT_NAME))); 867 l10n_util::GetString(IDS_PRODUCT_NAME)));
868 app_menu_->SetID(VIEW_ID_APP_MENU); 868 app_menu_->SetID(VIEW_ID_APP_MENU);
869 869
870 LoadRightSideControlsImages();
871
872 AddChildView(page_menu_);
873 AddChildView(app_menu_);
874
875 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kBookmarkMenu)) { 870 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kBookmarkMenu)) {
876 bookmark_menu_ = new BookmarkMenuButton(browser_); 871 bookmark_menu_ = new BookmarkMenuButton(browser_);
877 AddChildView(bookmark_menu_); 872 AddChildView(bookmark_menu_);
878 } else { 873 } else {
879 bookmark_menu_ = NULL; 874 bookmark_menu_ = NULL;
880 } 875 }
876
877 LoadRightSideControlsImages();
878
879 AddChildView(page_menu_);
880 AddChildView(app_menu_);
881 } 881 }
882 882
883 void ToolbarView::LoadLeftSideControlsImages() { 883 void ToolbarView::LoadLeftSideControlsImages() {
884 ThemeProvider* tp = GetThemeProvider(); 884 ThemeProvider* tp = GetThemeProvider();
885 885
886 SkColor color = tp->GetColor(BrowserThemeProvider::COLOR_BUTTON_BACKGROUND); 886 SkColor color = tp->GetColor(BrowserThemeProvider::COLOR_BUTTON_BACKGROUND);
887 SkBitmap* background = tp->GetBitmapNamed(IDR_THEME_BUTTON_BACKGROUND); 887 SkBitmap* background = tp->GetBitmapNamed(IDR_THEME_BUTTON_BACKGROUND);
888 888
889 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK)); 889 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK));
890 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H)); 890 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H));
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 962
963 // We use different menu button images if the locale is right-to-left. 963 // We use different menu button images if the locale is right-to-left.
964 if (UILayoutIsRightToLeft()) 964 if (UILayoutIsRightToLeft())
965 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE_RTL)); 965 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE_RTL));
966 else 966 else
967 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE)); 967 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE));
968 if (UILayoutIsRightToLeft()) 968 if (UILayoutIsRightToLeft())
969 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME_RTL)); 969 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME_RTL));
970 else 970 else
971 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME)); 971 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME));
972
973 if (bookmark_menu_ != NULL)
974 bookmark_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_BOOKMARK));
972 } 975 }
973 976
974 void ToolbarView::RunPageMenu(const gfx::Point& pt, gfx::NativeView parent) { 977 void ToolbarView::RunPageMenu(const gfx::Point& pt, gfx::NativeView parent) {
975 CreatePageMenu(); 978 CreatePageMenu();
976 page_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT); 979 page_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
977 } 980 }
978 981
979 void ToolbarView::RunAppMenu(const gfx::Point& pt, gfx::NativeView parent) { 982 void ToolbarView::RunAppMenu(const gfx::Point& pt, gfx::NativeView parent) {
980 CreateAppMenu(); 983 CreateAppMenu();
981 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT); 984 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 app_menu_contents_->AddItem(IDC_ABOUT, 1081 app_menu_contents_->AddItem(IDC_ABOUT,
1079 l10n_util::GetStringFUTF16( 1082 l10n_util::GetStringFUTF16(
1080 IDS_ABOUT, 1083 IDS_ABOUT,
1081 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME))); 1084 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)));
1082 app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE); 1085 app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
1083 app_menu_contents_->AddSeparator(); 1086 app_menu_contents_->AddSeparator();
1084 app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT); 1087 app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT);
1085 1088
1086 app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get())); 1089 app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get()));
1087 } 1090 }
OLDNEW
« no previous file with comments | « chrome/browser/views/bookmark_menu_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698