Issue 208010: Fix a coding error that was introduced in 26423.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208010: Fix a coding error that was introduced in 26423. (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, Mandeep Singh Baines

Visibility:
Public.

Description

Fix a coding error that was introduced in 26423. "file_list = file_list or []" would create a new empty list when an empty list is passed as a parameter, ditching the output parameter. TEST=hooks are now run on gclient sync BUG=none

Patch Set 1 #

Created: 11 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+2 lines, -2 lines)
	M	gclient_scm.py	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages