Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 208010: Fix a coding error that was introduced in 26423. (Closed)

Created:
11 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com, Mandeep Singh Baines
Visibility:
Public.

Description

Fix a coding error that was introduced in 26423. "file_list = file_list or []" would create a new empty list when an empty list is passed as a parameter, ditching the output parameter. TEST=hooks are now run on gclient sync BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gclient_scm.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
I had told msb@ to do that. This was a bad idea.
11 years, 3 months ago (2009-09-17 18:04:42 UTC) #1
bradn
11 years, 3 months ago (2009-09-17 18:06:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698