Issue 2080021: Chrome-side of tests for Pepper Device2D. This includes some bugfixes and min...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2080021: Chrome-side of tests for Pepper Device2D. This includes some bugfixes and min... (Closed)

Created:
10 years, 7 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, jam, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chrome-side of tests for Pepper Device2D. This includes some bugfixes and minor tweaks. TEST=this is BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48125

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -43 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ppapi_uitest.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.h	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.cc	View	1	8 chunks	+94 lines, -27 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.h	View	1	4 chunks	+50 lines, -7 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

This is the Chrome side to my DeviceContext patch. I will add a DEPS pull ...

10 years, 7 months ago (2010-05-24 20:55:13 UTC) #1

darin (slow to review)

10 years, 7 months ago (2010-05-24 23:05:32 UTC) #2

LGTM

http://codereview.chromium.org/2080021/diff/1/6
File webkit/glue/plugins/pepper_image_data.h (right):

http://codereview.chromium.org/2080021/diff/1/6#newcode85
webkit/glue/plugins/pepper_image_data.h:85: // iamge is mapped. The destructor
will put the image back into the previous
nit: iamge -> image

Expand Messages | Collapse Messages