Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 208002: Add all locales to the appropriate generated file lists in .gyp files.... (Closed)

Created:
11 years, 3 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Add all locales to the appropriate generated file lists in .gyp files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26494

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M app/app.gyp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M build/common.gypi View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/webkit.gyp View 1 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
11 years, 3 months ago (2009-09-17 06:16:41 UTC) #1
Ben Laurie (Chromium)
http://codereview.chromium.org/208002/diff/1/2 File app/app.gyp (right): http://codereview.chromium.org/208002/diff/1/2#newcode8 Line 8: 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py',], Do we really need loops ...
11 years, 3 months ago (2009-09-17 13:12:51 UTC) #2
Lei Zhang
Cleaned up. http://codereview.chromium.org/208002/diff/1/2 File app/app.gyp (right): http://codereview.chromium.org/208002/diff/1/2#newcode8 Line 8: 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py',], On 2009/09/17 13:12:51, ...
11 years, 3 months ago (2009-09-17 17:44:47 UTC) #3
Michael Moss
11 years, 3 months ago (2009-09-17 17:47:30 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698