Issue 2080018: Prepare push to trunk. Now working on version 2.2.12.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2080018: Prepare push to trunk. Now working on version 2.2.12. (Closed)

Created:
10 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.2.12. Committed: http://code.google.com/p/v8/source/detail?r=4699

Patch Set 1 #

Total comments: 3

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+18 lines, -0 lines	3 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-21 11:15:13 UTC) #2

LGTM

http://codereview.chromium.org/2080018/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/2080018/diff/1/3#newcode5
ChangeLog:5: Use 'full compiler' when debugging is active.  Page reload may be
I think "Page reload may be needed" should be changed to something like "This
will only take effect for functions compiled after debugging has been started,
so recompilation of all functions is required to get the full effect" and moved
to after "... fine grained.".

http://codereview.chromium.org/2080018/diff/1/3#newcode13
ChangeLog:13: Improve security when CPU profiling.
I think this should be changed to something like "Add filtering of CPU profiles
by security context".

http://codereview.chromium.org/2080018/diff/1/3#newcode15
ChangeLog:15: Fix crash bug on ARM when running without VFP.
VFP ->VFP3?

Expand Messages | Collapse Messages