Linux: Initial scaffolding for default plugin.

Linux: Initial scaffolding for default plugin.

Basically the linux version of http://codereview.chromium.org/2075006

BUG=10952
TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plug-in" text should look slightly different than it did before. Also, the plugin area is now grey instead of transparent. (this test depends on a small webkit shown below)

Requires commenting out

    if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin)
        return 0;

in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48315

[Nico, 2010-05-25 21:34:46]

estade: gtk stuff (plugin_impl_gtk.cc only)
piman: rest (or tell me about someone else who's good for reviewing plugin stuff
and who isn't on vacation :-) ).

[Evan Stade, 2010-05-25 23:31:18]

cool!

http://codereview.chromium.org/2079016/diff/14001/15003
File webkit/default_plugin/plugin_impl_gtk.cc (right):

http://codereview.chromium.org/2079016/diff/14001/15003#newcode23
webkit/default_plugin/plugin_impl_gtk.cc:23: : container_(0) {
s/0/NULL

http://codereview.chromium.org/2079016/diff/14001/15003#newcode37
webkit/default_plugin/plugin_impl_gtk.cc:37: if (mime_type == NULL ||
strlen(mime_type) == 0) {
maybe:

!mime_type || !*mime_type

(feel free to ignore this)

http://codereview.chromium.org/2079016/diff/14001/15003#newcode61
webkit/default_plugin/plugin_impl_gtk.cc:61: gtk_widget_show(box);
just show_all(container) ?

http://codereview.chromium.org/2079016/diff/14001/15003#newcode137
webkit/default_plugin/plugin_impl_gtk.cc:137: instance_,
4 space continuation indent

http://codereview.chromium.org/2079016/diff/14001/15004
File webkit/default_plugin/plugin_impl_gtk.h (right):

http://codereview.chromium.org/2079016/diff/14001/15004#newcode1
webkit/default_plugin/plugin_impl_gtk.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
year

http://codereview.chromium.org/2079016/diff/14001/15004#newcode58
webkit/default_plugin/plugin_impl_gtk.h:58: bool Initialize(void *module_handle,
NPP instance, NPMIMEType mime_type,
* on left

http://codereview.chromium.org/2079016/diff/14001/15004#newcode278
webkit/default_plugin/plugin_impl_gtk.h:278: GtkWidget* container_;
add blank line

http://codereview.chromium.org/2079016/diff/14001/15004#newcode279
webkit/default_plugin/plugin_impl_gtk.h:279:
DISALLOW_EVIL_CONSTRUCTORS(PluginInstallerImpl);
EVIL is deprecated

http://codereview.chromium.org/2079016/diff/14001/15004#newcode282
webkit/default_plugin/plugin_impl_gtk.h:282: 
subtract blank line

[piman, 2010-05-25 23:40:51]

LGTM on the NPAPI side.

[Nico, 2010-05-25 23:42:35]

Thanks!

http://codereview.chromium.org/2079016/diff/14001/15003
File webkit/default_plugin/plugin_impl_gtk.cc (right):

http://codereview.chromium.org/2079016/diff/14001/15003#newcode23
webkit/default_plugin/plugin_impl_gtk.cc:23: : container_(0) {
On 2010/05/25 23:31:18, Evan Stade wrote:
> s/0/NULL

Done.

http://codereview.chromium.org/2079016/diff/14001/15003#newcode61
webkit/default_plugin/plugin_impl_gtk.cc:61: gtk_widget_show(box);
On 2010/05/25 23:31:18, Evan Stade wrote:
> just show_all(container) ?

Neat. Done.

http://codereview.chromium.org/2079016/diff/14001/15003#newcode137
webkit/default_plugin/plugin_impl_gtk.cc:137: instance_,
On 2010/05/25 23:31:18, Evan Stade wrote:
> 4 space continuation indent

Done.

http://codereview.chromium.org/2079016/diff/14001/15004
File webkit/default_plugin/plugin_impl_gtk.h (right):

http://codereview.chromium.org/2079016/diff/14001/15004#newcode1
webkit/default_plugin/plugin_impl_gtk.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
On 2010/05/25 23:31:18, Evan Stade wrote:
> year

Done.

http://codereview.chromium.org/2079016/diff/14001/15004#newcode58
webkit/default_plugin/plugin_impl_gtk.h:58: bool Initialize(void *module_handle,
NPP instance, NPMIMEType mime_type,
On 2010/05/25 23:31:18, Evan Stade wrote:
> * on left

Done.

http://codereview.chromium.org/2079016/diff/14001/15004#newcode278
webkit/default_plugin/plugin_impl_gtk.h:278: GtkWidget* container_;
On 2010/05/25 23:31:18, Evan Stade wrote:
> add blank line

Done.

http://codereview.chromium.org/2079016/diff/14001/15004#newcode279
webkit/default_plugin/plugin_impl_gtk.h:279:
DISALLOW_EVIL_CONSTRUCTORS(PluginInstallerImpl);
On 2010/05/25 23:31:18, Evan Stade wrote:
> EVIL is deprecated

Done.

http://codereview.chromium.org/2079016/diff/14001/15004#newcode282
webkit/default_plugin/plugin_impl_gtk.h:282: 
On 2010/05/25 23:31:18, Evan Stade wrote:
> subtract blank line

Done.

[Evan Stade, 2010-05-25 23:52:35]

lgtm