Issue 2079007: Add metrics library tests. Some metrics daemon API cleanup.

Issue 2079007: Add metrics library tests. Some metrics daemon API cleanup. (Closed)

Created:
10 years, 7 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Add metrics library tests. Some metrics daemon API cleanup. Refactor the metrics daemon API a little so that we don't need to link in libmetrics into the daemon test binary.

Patch Set 2 : Fix Makefile's clean target. #

Patch Set 3 : A few more assertions. #

Patch Set 4 : This should really be a static. #

Total comments: 4

Patch Set 5 : address review comments. #

Patch Set 6 : A bit more cleanup. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -56 lines)			Patch
M	src/platform/metrics/Makefile	View	1	5 chunks	+13 lines, -4 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon.h	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon.cc	View		4 chunks	+10 lines, -13 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon_main.cc	View	1 2 3 4 5	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon_test.cc	View	1 2	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/platform/metrics/metrics_library.h	View	1 2 3 4 5	3 chunks	+28 lines, -1 line	0 comments	Download
M	src/platform/metrics/metrics_library.cc	View	1 2 3	4 chunks	+15 lines, -21 lines	0 comments	Download
A	src/platform/metrics/metrics_library_test.cc	View	1 2 3 4 5	1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

lgtm w/ nits http://codereview.chromium.org/2079007/diff/12001/7006 File src/platform/metrics/metrics_daemon_main.cc (right): http://codereview.chromium.org/2079007/diff/12001/7006#newcode13 src/platform/metrics/metrics_daemon_main.cc:13: MetricsDaemon::MetricsDaemon d; can you rename d ...

10 years, 7 months ago (2010-05-18 01:14:16 UTC) #2

petkov

http://codereview.chromium.org/2079007/diff/12001/7006 File src/platform/metrics/metrics_daemon_main.cc (right): http://codereview.chromium.org/2079007/diff/12001/7006#newcode13 src/platform/metrics/metrics_daemon_main.cc:13: MetricsDaemon::MetricsDaemon d; On 2010/05/18 01:14:16, sosa wrote: > can ...

10 years, 7 months ago (2010-05-18 05:32:16 UTC) #3

lgtm

Expand Messages | Collapse Messages