Issue 2078028: X64: Added inline conversion of double to smi for LikelySmiBinaryOp shifts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2078028: X64: Added inline conversion of double to smi for LikelySmiBinaryOp shifts. (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Added inline conversion of double to smi for LikelySmiBinaryOp shifts.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	src/x64/codegen-x64.cc	View		1 chunk	+37 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 7 months ago (2010-05-21 09:05:27 UTC) #2

LGTM.

http://codereview.chromium.org/2078028/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/2078028/diff/1/2#newcode7039
src/x64/codegen-x64.cc:7039: // Load integer value into answer register using
truncation.
This is the case we also hope to avoid by using the to_int32 information on the
expression producing the left operand.  Have we implemented that (on adds and
multiplies, for example?)

Expand Messages | Collapse Messages