Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2078026: remove dependencies on obsolete chrome os login helper binaries (Closed)

Created:
10 years, 7 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Visibility:
Public.

Description

remove dependencies on obsolete chrome os login helper binaries. This has a nice side effect of getting rid of some circular GYP dependencies introduced by these targets. BUG=35308 TEST=build chrome, look for session and emit_login_prompt_ready in the output dir; they should not be there. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 7 months ago (2010-05-20 23:19:57 UTC) #1
Daniel Erat
10 years, 7 months ago (2010-05-20 23:31:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698