Issue 2078019: For notifications, use the same shadow border that the autocomplete dropdown ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2078019: For notifications, use the same shadow border that the autocomplete dropdown ... (Closed)

Created:
10 years, 7 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

For notifications, use the same shadow border that the autocomplete dropdown uses rather than using images. This looks a lot sharper. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47750

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -62 lines)			Patch
M	chrome/browser/resources/notification_icon.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/notifications/balloon_view.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/views/notifications/balloon_view.cc	View	7 chunks	+82 lines, -55 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM. Pathing code makes my head hurt.