ARM: Fix generating two ldr instructions in place of ldrd....

ARM: Fix generating two ldr instructions in place of ldrd.

When ldrd is not available two ldr instructions are generated. This fixes these in the case where the register used in the memory operand is the same as the first register in the register pair receiving the values.

All tests now run on ARM with the flag --special-command="@ --noenable-vfp3". Running without VFP3 support in the simulator causes more ldrd instructions to be used, and the default build configuration does not utilize ldrd, but generated tow ldr instructions.

Committed: http://code.google.com/p/v8/source/detail?r=4667

[Erik Corry, 2010-05-17 18:45:15]

LGTM, thanks for fixing this!

[zhangk, 2010-05-17 18:50:54]

http://codereview.chromium.org/2078013/diff/1/2
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/2078013/diff/1/2#newcode1366
src/arm/assembler-arm.cc:1366: dst1.code_ = dst1.code_ + 1;
I think it's better to use dst1.code_ = dst1.code() + 1;

http://codereview.chromium.org/2078013/diff/1/2#newcode1387
src/arm/assembler-arm.cc:1387: src1.code_ = src1.code_ + 1;
Also here.

[Søren Thygesen Gjesse, 2010-05-18 06:36:17]

http://codereview.chromium.org/2078013/diff/1/2
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/2078013/diff/1/2#newcode1366
src/arm/assembler-arm.cc:1366: dst1.code_ = dst1.code_ + 1;
On 2010/05/17 18:50:54, zhangk wrote:
> I think it's better to use dst1.code_ = dst1.code() + 1;

Done. Added a set_code() to Register as well (even though code_ is public.

http://codereview.chromium.org/2078013/diff/1/2#newcode1387
src/arm/assembler-arm.cc:1387: src1.code_ = src1.code_ + 1;
On 2010/05/17 18:50:54, zhangk wrote:
> Also here.

Done.

[zhangk, 2010-05-18 17:16:43]

It looks good to me.