Issue 2078005: Modified codegen-arm.cc to no longer use V8_NATIVE_REGEXP, but to use...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2078005: Modified codegen-arm.cc to no longer use V8_NATIVE_REGEXP, but to use... (Closed)

Created:
10 years, 7 months ago by pgalizia

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Erik Corry, Mads Ager (chromium)

CC:
v8-dev, cros.approvers_codeaurora.org, Micah C

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Modified codegen-arm.cc to no longer use V8_NATIVE_REGEXP, but to use V8_INTERPRETED_REGEXP (as per Issue 1635001). BUG=none TEST=Ran v8 tests, as well as against current Chromium browser. Committed: http://code.google.com/p/v8/source/detail?r=4655

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/arm/codegen-arm.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pgalizia

This patch removes the V8_NATIVE_REGEXP flag from codegen-arm.cc and replaces it with the V8_INTERPRETED_REGEXP to ...

10 years, 7 months ago (2010-05-13 19:23:24 UTC) #1

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-14 13:55:04 UTC) #3

On 2010/05/14 13:44:42, Søren Gjesse wrote:
> LGTM

Committed as r4655. Closing issue.

Expand Messages | Collapse Messages