Issue 2075019: Cleanup of adding pristine image and fixing of symlinks in developer image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2075019: Cleanup of adding pristine image and fixing of symlinks in developer image. (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Nick Sanders, djmm

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Cleanup of adding pristine image and fixing of symlinks in developer image. TEST=Tested with building a new image, looking in the output directory, running the image and running vi.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -3 lines)			Patch
M	src/scripts/archive_build.sh	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	src/scripts/build_image	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/scripts/common.sh	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/scripts/image_to_usb.sh	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/scripts/mount_gpt_image.sh	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

lgtm on the symlink stuff, not sure about archive build? http://codereview.chromium.org/2075019/diff/1/2 File src/scripts/archive_build.sh (right): http://codereview.chromium.org/2075019/diff/1/2#newcode108 ...

10 years, 7 months ago (2010-05-20 00:56:55 UTC) #2

Nick Sanders

lgtm, chatted w/ sosa about archive builds, will move deletion a bit later in the ...

10 years, 7 months ago (2010-05-20 01:05:04 UTC) #3

sosa

10 years, 7 months ago (2010-05-20 01:05:48 UTC) #4

Djmm can you take a look at the archive_build change? This removes the dev image
from the buildbot zip (only pristine and test will be there)

Expand Messages | Collapse Messages