Teach build_image to pull from buildbot as necessary when the package is unavailable locally.

Teach build_image to pull from buildbot as necessary when the package is unavailable locally.

TEST=./build_package && ./build_image for x86-generic and voguet20

[Mandeep Singh Baines, 2010-05-21 15:03:11]

LGTM

anush@chromium.org (anush@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, rtc, tedbo, sosa,
>
> Description:
> Teach build_image to pull from buildbot as necessary when the package is
> unavailable locally.
>
> TEST=./build_package && ./build_image for x86-generic and voguet20
>
> Please review this at http://codereview.chromium.org/2074019/show
>
> SVN Base: ssh://git@chromiumos-git/chromeos
>
> Affected files:
>   M src/scripts/build_image
>
>
> Index: src/scripts/build_image
> diff --git a/src/scripts/build_image b/src/scripts/build_image
> index  
>
0ba6531200fd7968216c4ce067957c4d90a34ddb..fbad19a4d39cfc1455b83fc10cd97d1c84b8f9d2

> 100755
> --- a/src/scripts/build_image
> +++ b/src/scripts/build_image
> @@ -207,7 +207,7 @@ create_developer_image() {
>    # Install developer packages described in chromeos-dev.
>    sudo INSTALL_MASK="$INSTALL_MASK" emerge-${BOARD} \
>        --root="$root_dev_dir" --root-deps=rdeps \
> -      --usepkgonly chromeos-dev $EMERGE_JOBS
> +      --getbinpkg --usepkg chromeos-dev $EMERGE_JOBS
>
>    # Re-run ldconfig to fix /etc/ldconfig.so.cache.
>    sudo /sbin/ldconfig -r "$root_fs_dir"
> @@ -378,7 +378,7 @@ sudo mount --bind "${STATEFUL_DIR}/var" 
> "${ROOT_FS_DIR}/var"
>  # image size as much as possible.
>  sudo INSTALL_MASK="$INSTALL_MASK" emerge-${BOARD} \
>    --root="$ROOT_FS_DIR" --root-deps=rdeps \
> -  --usepkgonly chromeos $EMERGE_JOBS
> +  --getbinpkg --usepkg chromeos $EMERGE_JOBS
>
>  # Extract the kernel from the root filesystem for use by the GPT image.  
> Legacy
>  # BIOS will use the kernel in the rootfs (via syslinux), Chrome OS BIOS  
> will
>
>

[Nasser Grainawi, 2010-05-21 15:44:09]

One nit.

http://codereview.chromium.org/2074019/diff/1/2
File src/scripts/build_image (right):

http://codereview.chromium.org/2074019/diff/1/2#newcode210
src/scripts/build_image:210: --getbinpkg --usepkg chromeos-dev $EMERGE_JOBS
Isn't this redundant? From 'man emerge':
--getbinpkg[=n] (-g)
....
This option implies -k.
--usepkg[=n] (-k)

[anush, 2010-05-21 16:02:44]

Good point. Usually I prefer explicitly stating the options since I
guess they are less likely to change than implicit dependencies (and
better readability?) .

If you feel strongly about it I can drop the --usepkg.

Thanks
Anush

On Fri, May 21, 2010 at 8:44 AM,  <nasser@codeaurora.org> wrote:
> One nit.
>
>
> http://codereview.chromium.org/2074019/diff/1/2
> File src/scripts/build_image (right):
>
> http://codereview.chromium.org/2074019/diff/1/2#newcode210
> src/scripts/build_image:210: --getbinpkg --usepkg chromeos-dev
> $EMERGE_JOBS
> Isn't this redundant? From 'man emerge':
> --getbinpkg[=n] (-g)
> ....
> This option implies -k.
> --usepkg[=n] (-k)
>
> http://codereview.chromium.org/2074019/show
>

[sosa, 2010-05-21 16:12:13]

I'd prefer if you left it in so it's clear.  LGTM

On Fri, May 21, 2010 at 9:02 AM, Anush Elangovan <anush@chromium.org> wrote:
> Good point. Usually I prefer explicitly stating the options since I
> guess they are less likely to change than implicit dependencies (and
> better readability?) .
>
> If you feel strongly about it I can drop the --usepkg.
>
> Thanks
> Anush
>
> On Fri, May 21, 2010 at 8:44 AM,  <nasser@codeaurora.org> wrote:
>> One nit.
>>
>>
>> http://codereview.chromium.org/2074019/diff/1/2
>> File src/scripts/build_image (right):
>>
>> http://codereview.chromium.org/2074019/diff/1/2#newcode210
>> src/scripts/build_image:210: --getbinpkg --usepkg chromeos-dev
>> $EMERGE_JOBS
>> Isn't this redundant? From 'man emerge':
>> --getbinpkg[=n] (-g)
>> ....
>> This option implies -k.
>> --usepkg[=n] (-k)
>>
>> http://codereview.chromium.org/2074019/show
>>
>

[Nasser Grainawi, 2010-05-21 16:37:28]

No strong feelings, lgtm. :)

Chris Sosa wrote:
> I'd prefer if you left it in so it's clear.  LGTM
> 
> On Fri, May 21, 2010 at 9:02 AM, Anush Elangovan <anush@chromium.org> wrote:
>> Good point. Usually I prefer explicitly stating the options since I
>> guess they are less likely to change than implicit dependencies (and
>> better readability?) .
>>
>> If you feel strongly about it I can drop the --usepkg.
>>
>> Thanks
>> Anush
>>
>> On Fri, May 21, 2010 at 8:44 AM,  <nasser@codeaurora.org> wrote:
>>> One nit.
>>>
>>>
>>> http://codereview.chromium.org/2074019/diff/1/2
>>> File src/scripts/build_image (right):
>>>
>>> http://codereview.chromium.org/2074019/diff/1/2#newcode210
>>> src/scripts/build_image:210: --getbinpkg --usepkg chromeos-dev
>>> $EMERGE_JOBS
>>> Isn't this redundant? From 'man emerge':
>>> --getbinpkg[=n] (-g)
>>> ....
>>> This option implies -k.
>>> --usepkg[=n] (-k)
>>>
>>> http://codereview.chromium.org/2074019/show
>>>