Issue 2072010: Update Chrome to use the new int64-typedefed module, instance, and resources ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2072010: Update Chrome to use the new int64-typedefed module, instance, and resources ... (Closed)

Created:
10 years, 7 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, jam, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Update Chrome to use the new int64-typedefed module, instance, and resources in ppapi TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47681

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -28 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

brettw

I'll also pull in the corresponding ppapi version once I check that in

10 years, 7 months ago (2010-05-18 21:13:54 UTC) #1

darin (slow to review)

10 years, 7 months ago (2010-05-18 21:24:01 UTC) #2

LGTM

Nice to see NullPPResource replaced with NULL!