Add new bootstub source.

Add new bootstub source.

This is the inline bootloader that will be embedded in the signed kernel
partition.

[Randall Spangler, 2010-05-21 16:36:20]

LGTM with a few suggestions for comment/doc changes so we don't forget to clean
up some of the initial debugging/hardcoded stuff.

http://codereview.chromium.org/2071024/diff/1/5
File src/third_party/bootstub/files/bootstub.c (right):

http://codereview.chromium.org/2071024/diff/1/5#newcode21
src/third_party/bootstub/files/bootstub.c:21: struct hacked_params {
Add a source reference/doc url to where zeropage is defined?

http://codereview.chromium.org/2071024/diff/1/5#newcode86
src/third_party/bootstub/files/bootstub.c:86: // This is handy to write status
codes to the LEDs for debugging.
Will we leave calls to this in the final code version?

http://codereview.chromium.org/2071024/diff/1/5#newcode98
src/third_party/bootstub/files/bootstub.c:98: // Danger Will Robinson: this is
just a guess at the size and alignment!
For ease of finding the initial guesses and hard-coded-values, use a consistent
TODO: tag?  I assume we'll clean all these issues up after feature-complete,
before final release...

[Bill Richardson, 2010-05-21 18:01:20]

http://codereview.chromium.org/2071024/diff/1/5
File src/third_party/bootstub/files/bootstub.c (right):

http://codereview.chromium.org/2071024/diff/1/5#newcode86
src/third_party/bootstub/files/bootstub.c:86: // This is handy to write status
codes to the LEDs for debugging.
On 2010/05/21 16:36:20, Randall Spangler wrote:
> Will we leave calls to this in the final code version?

Sure. It's two instructions, and doesn't hurt anything if the LED hardware isn't
present.

http://codereview.chromium.org/2071024/diff/1/5#newcode98
src/third_party/bootstub/files/bootstub.c:98: // Danger Will Robinson: this is
just a guess at the size and alignment!
On 2010/05/21 16:36:20, Randall Spangler wrote:
> For ease of finding the initial guesses and hard-coded-values, use a
consistent
> TODO: tag?  I assume we'll clean all these issues up after feature-complete,
> before final release...

Hm. Good point. thanks.

[Randall Spangler, 2010-05-21 18:37:26]

LGTM

http://codereview.chromium.org/2071024/diff/5001/6004
File src/third_party/bootstub/files/bootstub.c (right):

http://codereview.chromium.org/2071024/diff/5001/6004#newcode41
src/third_party/bootstub/files/bootstub.c:41: // aligned to a 4K boundary,
because that's where our build system puts it.
Does this also need a FIXME / reference?