Issue 207061: Added support for getting and setting the CommandBuffer token and error....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207061: Added support for getting and setting the CommandBuffer token and error.... (Closed)

Created:
11 years, 3 months ago by apatrick

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (Google)

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Added support for getting and setting the CommandBuffer token and error. See o3d/command_buffer/service/cross/cmd_buffer_engine.h. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26871

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -1 line)			Patch
M	o3d/gpu_plugin/command_buffer.h	View	4 chunks	+35 lines, -0 lines	0 comments	Download
M	o3d/gpu_plugin/command_buffer.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	o3d/gpu_plugin/command_buffer_unittest.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Ken Russell (Google)

I assume that SetError won't be accessible to the client. LGTM

11 years, 3 months ago (2009-09-22 22:20:25 UTC) #2

Correct.