Issue 207054: Have the dock menu "New Incognito Window" item always open a new...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207054: Have the dock menu "New Incognito Window" item always open a new... (Closed)

Created:
11 years, 3 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Have the dock menu "New Incognito Window" item always open a new window, not open a tab in an existing incognito window. (Vedran Šajatović) BUG=21175 TEST=New Incognito Window from dock with an incognito window already open Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26819

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	AUTHORS	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/app_controller_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

Landing this part of Vedran's patch from http://codereview.chromium.org/196113. (He's signed the CLA.)

11 years, 3 months ago (2009-09-22 16:25:38 UTC) #1

LGTM, and thanks, Vedran.

Expand Messages | Collapse Messages