[Mac] Convert Omnibox paste-and-go to use AutocompleteTextFieldObserver.

[Mac] Convert Omnibox paste-and-go to use AutocompleteTextFieldObserver.

Obvious result of Rohit's addition of paste-and-go and my refactor to
add AutocompleteTextFieldObserver.  Bonus prize of unit tests for
cocoa/ part of Rohit's change.

[Scott Hess - ex-Googler, 2009-09-21 22:56:05]

Sorry about the egregious conversion of -insertMenuItem: to -addMenuItem:.  When
writing the test, I was pondering how deeply to test the ordering and whether to
share constants or what, and this seemed more robust.

[rohitrao (ping after 24h), 2009-09-23 17:47:12]

LGTM

There are many other tests that would benefit from GMock and OCMock.  I'll put
it down on my list to find and fix them :)

http://codereview.chromium.org/207047/diff/1/7
File chrome/browser/cocoa/autocomplete_text_field_editor.mm (right):

http://codereview.chromium.org/207047/diff/1/7#newcode81
Line 81: [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_CUT)
This change is fine.  I think I was working off the apple docs, which all used
insertItem.

http://codereview.chromium.org/207047/diff/1/8
File chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm (right):

http://codereview.chromium.org/207047/diff/1/8#newcode178
Line 178: // TODO(shess): Check the titles, too?  Enforce order, or allow
We should enforce order, because the menu should always go Cut/Copy/Paste.

[Scott Hess - ex-Googler, 2009-09-23 19:45:20]

http://codereview.chromium.org/207047/diff/1/8
File chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm (right):

http://codereview.chromium.org/207047/diff/1/8#newcode178
Line 178: // TODO(shess): Check the titles, too?  Enforce order, or allow
On 2009/09/23 17:47:12, rohitrao wrote:
> We should enforce order, because the menu should always go Cut/Copy/Paste.

I'll strip the "enforce order" part from the todo.

[Scott Hess - ex-Googler, 2009-09-23 20:14:49]

And I will, um, remove the test which didn't pass because it tested code which
didn't exist until the code review I'll be sending you presently.  Sigh and
double-sigh.

On 2009/09/23 19:45:20, shess wrote:
> http://codereview.chromium.org/207047/diff/1/8
> File chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm (right):
> 
> http://codereview.chromium.org/207047/diff/1/8#newcode178
> Line 178: // TODO(shess): Check the titles, too?  Enforce order, or allow
> On 2009/09/23 17:47:12, rohitrao wrote:
> > We should enforce order, because the menu should always go Cut/Copy/Paste.
> 
> I'll strip the "enforce order" part from the todo.