Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 207032: Revert "Extensions: tab.title should not be undefined." (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 2d3e70ceeb5d32853b3cc92d17f4c1b5789892f9..12028c241572fa1ba614827a124fcc6b58e1f969 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -115,9 +115,10 @@ DictionaryValue* ExtensionTabUtil::CreateTabValue(
result->SetString(keys::kStatusKey, GetTabStatusText(status));
result->SetBoolean(keys::kSelectedKey,
tab_strip && tab_index == tab_strip->selected_index());
- result->SetString(keys::kTitleKey, UTF16ToWide(contents->GetTitle()));
if (status != TAB_LOADING) {
+ result->SetString(keys::kTitleKey, UTF16ToWide(contents->GetTitle()));
+
NavigationEntry* entry = contents->controller().GetActiveEntry();
if (entry) {
if (entry->favicon().is_valid())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698