Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 207030: Fix try job status PRESUBMIT check when an issue is private.... (Closed)

Created:
11 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix try job status PRESUBMIT check when an issue is private. TEST=presubmit doesn't throw an exception on private issues BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 3 months ago (2009-09-18 17:14:03 UTC) #1
wtc
LGTM.
11 years, 3 months ago (2009-09-18 17:25:26 UTC) #2
wtc
11 years, 3 months ago (2009-09-18 17:47:20 UTC) #3
I verified that the review being private was the problem.
After I unchecked the "Private" box, my "gcl commit" command
succeeded.

Powered by Google App Engine
This is Rietveld 408576698