Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 207025: NaCl-Chrome integration (Closed)

Created:
11 years, 3 months ago by gregoryd
Modified:
9 years, 7 months ago
Reviewers:
bradn
CC:
chromium-reviews_googlegroups.com, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

This is a copy of http://codereview.chromium.org/153002/show First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26540

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+905 lines, -33 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/format_macros.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/nacl_process_host.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/nacl_process_host.cc View 1 1 chunk +187 lines, -0 lines 0 comments Download
M chrome/browser/plugin_service.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/sandbox_policy.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 6 chunks +77 lines, -0 lines 0 comments Download
M chrome/common/child_process_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A chrome/common/nacl_messages.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/common/nacl_messages_internal.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/common/nacl_types.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/sandbox_init_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/nacl/nacl_main.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/nacl/nacl_thread.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/nacl/nacl_thread.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/nacl/sel_main.cc View 1 1 chunk +210 lines, -0 lines 0 comments Download
M chrome/renderer/render_process.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_list.h View 4 chunks +16 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_list.cc View 5 chunks +42 lines, -1 line 0 comments Download
M webkit/glue/plugins/plugin_list_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_list_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 2 chunks +31 lines, -23 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698