Issue 207019: Enable bookmark sync building by default for Chromium builds on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207019: Enable bookmark sync building by default for Chromium builds on windows. (Closed)

Created:
11 years, 3 months ago by chron_chromium.org

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Enable bookmark sync building by default for Chromium builds on windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26535

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	chrome/chrome.gyp	View	1 2 3 4	1 chunk	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chron_chromium.org

Talked to ncarter, he suggested we turn this on.

11 years, 3 months ago (2009-09-17 21:03:25 UTC) #1

tim (not reviewing)

11 years, 3 months ago (2009-09-17 21:43:18 UTC) #2

LGTM

http://codereview.chromium.org/207019/diff/1/2
File chrome/chrome.gyp (right):

http://codereview.chromium.org/207019/diff/1/2#newcode133
Line 133: 'use_syncapi_stub%': 0,
nit- ^H^H^H^H^H^H^H

Expand Messages | Collapse Messages