Issue 207004: Avoid gyp_chromium duplicating an include that's already in the command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207004: Avoid gyp_chromium duplicating an include that's already in the command line. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, yaar, sgk

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Avoid gyp_chromium duplicating an include that's already in the command line. Fixes automatic makefile regeneration from duplicating gcc flags and causing a full rebuild each time. BUG=none TEST=make && touch chrome/chrome.gyp && make Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26415

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+31 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages