Issue 2070001: Remove webkit_support_in_chromium.gyp and use webkit_support.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2070001: Remove webkit_support_in_chromium.gyp and use webkit_support.gyp (Closed)

Created:
10 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
tkent, darin (slow to review)

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Remove webkit_support_in_chromium.gyp and use webkit_support.gyp instead. features.gypi isn't needed by glue, appcache or database. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47238

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -54 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/locales/locales.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/nacl.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/support/webkit_support.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	webkit/support/webkit_support_in_chromium.gyp	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	3 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

tony

This will have to wait until DEPS is rolled to pick up r59346.

10 years, 7 months ago (2010-05-13 06:24:23 UTC) #1

LGTM