Issue 2069009: chunk of straightforward ifdef/include changes for BSD port...

Issue 2069009: chunk of straightforward ifdef/include changes for BSD port... (Closed)

Created:
10 years, 7 months ago by Peter Valchev

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, cbentzel+watch_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

chunk of straightforward ifdef/include changes for BSD port based on sprewell's patch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47687

Patch Set 1 #

Total comments: 4

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -18 lines)			Patch
M	ipc/ipc_channel_posix.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	9 chunks	+9 lines, -9 lines	1 comment	Download
M	net/base/listen_socket.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/net_util.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	net/base/sys_addrinfo.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/x509_certificate_unittest.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	net/socket/tcp_client_socket_libevent.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/tools/hresolv/hresolv.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/image_operations.cc	View	2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM, some suggestions inline http://codereview.chromium.org/2069009/diff/1/2 File ipc/ipc_channel_posix.cc (right): http://codereview.chromium.org/2069009/diff/1/2#newcode687 ipc/ipc_channel_posix.cc:687: // On Linux, the Hello ...

10 years, 7 months ago (2010-05-19 11:50:11 UTC) #2

Peter Valchev

10 years, 7 months ago (2010-05-19 18:21:42 UTC) #3

On 2010/05/19 11:50:11, Evan Martin wrote:
> LGTM, some suggestions inline

Changed done & submitted, thanks! (BTW issue 2089010 is another chunk I sent
last week, not sure if you noticed it.)


> http://codereview.chromium.org/2069009/diff/1/2
> File ipc/ipc_channel_posix.cc (right):
> 
> http://codereview.chromium.org/2069009/diff/1/2#newcode687
> ipc/ipc_channel_posix.cc:687: // On Linux, the Hello message from the client
to
> the server
> s/Linux/non-Mac/
> 
> http://codereview.chromium.org/2069009/diff/1/5
> File net/base/net_util.cc (right):
> 
> http://codereview.chromium.org/2069009/diff/1/5#newcode29
> net/base/net_util.cc:29: #include <netinet/in.h>
> Is this ordering required?  We typically alphabetize headers.  If it can't be
> alphabetized, I suggest sticking a comment beside the one that is out of order
> so that someone else doesn't "fix" it later.
> 
> http://codereview.chromium.org/2069009/diff/1/7
> File net/base/x509_certificate_unittest.cc (right):
> 
> http://codereview.chromium.org/2069009/diff/1/7#newcode297
> net/base/x509_certificate_unittest.cc:297: #if !defined(OS_MACOSX)
> It is weird this code doesn't happen on OS X.
> 
> http://codereview.chromium.org/2069009/diff/1/10
> File skia/ext/image_operations.cc (right):
> 
> http://codereview.chromium.org/2069009/diff/1/10#newcode272
> skia/ext/image_operations.cc:272: // Currently only works on Linux/BSD because
> this is the only platform where
> s/this is ...platform/these are ...platforms/
> (and then re-wrap to 80 cols)

Expand Messages | Collapse Messages