Commiting http://codereview.chromium.org/2017007/show on behalf of rkc@chromi...

app/x11_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines utility functions for X11 (Linux only). This code has been
 // ported from XCB since we can't use XCB on Ubuntu while its 32-bit support
 // remains woefully incomplete.
 
 #include "app/x11_util.h"
 
@@ skipping 718 matching lines @@
   memcpy(&(*png_representation)[old_size], data, length);
   return CAIRO_STATUS_SUCCESS;
 }
 
 void GrabWindowSnapshot(GtkWindow* gtk_window,
                         std::vector<unsigned char>* png_representation) {
   GdkWindow* gdk_window = GTK_WIDGET(gtk_window)->window;
   Display* display = GDK_WINDOW_XDISPLAY(gdk_window);
   XID win = GDK_WINDOW_XID(gdk_window);
   XWindowAttributes attr;
-  if (XGetWindowAttributes(display, win, &attr) != 0) {
+  if (XGetWindowAttributes(display, win, &attr) == 0) {
     LOG(ERROR) << "Couldn't get window attributes";
     return;
   }
   XImage* image = XGetImage(
       display, win, 0, 0, attr.width, attr.height, AllPlanes, ZPixmap);
   if (!image) {
     LOG(ERROR) << "Couldn't get image";
     return;
   }
   if (image->depth != 24) {
@@ skipping 30 matching lines @@
   event.xclient.format = 32;
   event.xclient.data.l[0] = desktop;
   event.xclient.data.l[1] = 1;  // source indication
 
   int result = XSendEvent(GetXDisplay(), GetX11RootWindow(), False,
                           SubstructureNotifyMask, &event);
   return result == Success;
 }
 
 }  // namespace x11_util