Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068004: Commiting http://codereview.chromium.org/2017007/show on behalf of rkc@chromi... (Closed)

Created:
10 years, 7 months ago by zel
Modified:
9 years, 6 months ago
Reviewers:
mal
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Commiting http://codereview.chromium.org/2017007/show on behalf of rkc@chromium.org. This change hooks issue report dialog with Google Feedback backend for ChromeOS. The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems. Image and System Info reporting is disabled at the moment; for image, we need feedback to get their changes in production, for reporting, the system scripts need to be added (basic Chrome and OS version info is being sent with the report) BUG=chromium-os:2761 TEST=none, work in progress TBR=zelidrag Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47244

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+794 lines, -116 lines) Patch
M app/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/mac_util.mm View 2 chunks +4 lines, -1 line 0 comments Download
M base/mac_util_unittest.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/bug_report_util.h View 2 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/bug_report_util.cc View 1 5 chunks +70 lines, -94 lines 0 comments Download
M chrome/browser/cocoa/bug_report_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bug_report_window_controller.mm View 2 chunks +6 lines, -2 lines 0 comments Download
A chrome/browser/userfeedback/proto/annotations.proto View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/common.proto View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/config.proto View 1 chunk +139 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/dom.proto View 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/extension.proto View 1 chunk +99 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/math.proto View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/userfeedback/proto/web.proto View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/views/bug_report_view.h View 6 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/views/bug_report_view.cc View 8 chunks +96 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +65 lines, -0 lines 1 comment Download
M third_party/protobuf2/protobuf.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
mal
10 years, 7 months ago (2010-05-14 22:28:31 UTC) #1 
http://codereview.chromium.org/2068004/diff/9001/10020
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/2068004/diff/9001/10020#newcode3485
chrome/chrome_browser.gypi:3485:
'../third_party/protobuf2/protobuf.gyp:protobuf',
Delete these two lines: they're redefining 'dependencies' from above (line 3472)

Powered by Google App Engine
This is Rietveld 408576698