Issue 2067018: Break gyp cycles on Linux.

Issue 2067018: Break gyp cycles on Linux. (Closed)

Created:
10 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Michael Moss

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Break gyp cycles on Linux. The cycle is between installer.gyp and chrome.gyp. The fix is to switch installer.gyp into installer.gypi and include it into chrome.gyp BUG=35308 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48007

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : win fixes #

Patch Set 4 : update (c) #

Total comments: 1

Patch Set 5 : remove duplicate vars #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+318 lines, -322 lines)			Patch
M	build/all.gyp	View	1 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	build/gyp_chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	5 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_dll.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_exe.gypi	View		4 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/chrome_installer.gypi	View	1 2 3 4	26 chunks	+129 lines, -133 lines	0 comments	Download
A	chrome/chrome_installer_util.gypi	View	1 2 3	1 chunk	+160 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
D	chrome/installer/installer_util.gypi	View		1 chunk	+0 lines, -160 lines	0 comments	Download
M	chrome/installer/mini_installer.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		7 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM! http://codereview.chromium.org/2067018/diff/6001/7007 File chrome/chrome_installer.gypi (right): http://codereview.chromium.org/2067018/diff/6001/7007#newcode6 chrome/chrome_installer.gypi:6: 'variables': { Do you need this block now? ...

10 years, 7 months ago (2010-05-21 14:02:25 UTC) #2

tony

10 years, 7 months ago (2010-05-24 00:35:10 UTC) #3

On 2010/05/21 14:02:25, Mark Mentovai wrote:
> LGTM!
> 
> http://codereview.chromium.org/2067018/diff/6001/7007
> File chrome/chrome_installer.gypi (right):
> 
> http://codereview.chromium.org/2067018/diff/6001/7007#newcode6
> chrome/chrome_installer.gypi:6: 'variables': {
> Do you need this block now? Will we get these variables from chrome.gyp?

Good catch, I was able to remove version_py and version_path.

Expand Messages | Collapse Messages