Issue 2067016: Added support for critical notification on low battery.

Issue 2067016: Added support for critical notification on low battery. (Closed)

Created:
10 years, 7 months ago by Sean Parent

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Added support for critical notification on low battery. Added support for urgent system notifications Added support for icons in system notifications and added a low battery icon. BUG=http://code.google.com/p/chromium-os/issues/detail?id=2692 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47703

Patch Set 1 #

Patch Set 2 : Fix comment per style guide #

Total comments: 2

Patch Set 3 : git commit -a #

Patch Set 4 : Minor comment tweaks. #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -24 lines)			Patch
A	chrome/app/theme/notification_low_battery.png	View		Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/low_battery_observer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/low_battery_observer.cc	View	1 2 3	3 chunks	+28 lines, -14 lines	1 comment	Download
M	chrome/browser/chromeos/notifications/system_notification.h	View	1 2 3	3 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/system_notification.cc	View		3 chunks	+27 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sean Parent

Added low battery icon to notification and use update and show for critical battery notification.

10 years, 7 months ago (2010-05-18 23:15:58 UTC) #1

oshima

i thought we're going to show 15, 10 and 5 min but if this is ...

10 years, 7 months ago (2010-05-19 17:21:31 UTC) #2

Sean Parent

I added an upper limit to avoid having the notification re-appear as the battery estimate ...

10 years, 7 months ago (2010-05-19 17:38:00 UTC) #3

oshima

10 years, 7 months ago (2010-05-19 19:23:51 UTC) #4

lgtm

just one minor comment about the comment below.

http://codereview.chromium.org/2067016/diff/17001/18003
File chrome/browser/chromeos/low_battery_observer.cc (right):

http://codereview.chromium.org/2067016/diff/17001/18003#newcode38
chrome/browser/chromeos/low_battery_observer.cc:38: bool line_power =
object->line_power_on() || remaining == base::TimeDelta();
I'm guessing that remaining == 0 mean we're calculating, correct? can you
mention it in the comment?

Expand Messages | Collapse Messages