Issue 2064009: Version 1.02 of the Realtek USB card reader driver fixes the lsusb hang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2064009: Version 1.02 of the Realtek USB card reader driver fixes the lsusb hang. (Closed)

Created:
10 years, 7 months ago by bfreed

Modified:
9 years, 4 months ago

Reviewers:
mbligh, hughd

CC:
chromium-os-reviews_chromium.org, mbligh, Mandeep Singh Baines, Olof Johansson

Base URL:
ssh://git@chromiumos-git/kernel.git

Visibility:
Public.

Version 1.02 of the Realtek USB card reader driver fixes the lsusb hang. The important part appears to be the mutex lock in rts51x_polling_func().

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -39 lines)			Patch
	M	drivers/usb/storage/realtek_cr.c	View		13 chunks	+65 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

hughd

I've looked through it for a while, but I've failed to grasp what the important ...

10 years, 7 months ago (2010-05-18 03:17:37 UTC) #2

mbligh_google.com

10 years, 7 months ago (2010-05-18 21:59:39 UTC) #3

LGTM

> Are we supposed to say LGTM from ignorance?

As long as it looks vaguely sane, and seems to work, I tend to ;-)