Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 206033: Print the frame where the window.print() call origins from.... (Closed)

Created:
11 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam
Visibility:
Public.

Description

On 'window.print()' javascript command, print only the frame that is represented by 'window'. The behavior was broken in r20876. BUG=18749 TEST=window.print() on a subframe works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26847

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/renderer/render_view.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
11 years, 3 months ago (2009-09-16 18:56:22 UTC) #1
M-A Ruel
Changing reviewer
11 years, 3 months ago (2009-09-21 15:02:38 UTC) #2
stuartmorgan
http://codereview.chromium.org/206033/diff/3001/3002 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/206033/diff/3001/3002#newcode2630 Line 2630: if (webview()) { Do we really still need ...
11 years, 3 months ago (2009-09-21 23:42:59 UTC) #3
M-A Ruel
updated
11 years, 3 months ago (2009-09-22 19:46:17 UTC) #4
stuartmorgan
11 years, 3 months ago (2009-09-22 19:47:28 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698