Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 206016: The "make default" button... (Closed)

Created:
11 years, 3 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Keyword editor fixes: The "make default" button Auto size to always fit the text. Be a small style control, look better (changes font). General fix up so the window resizes. TableView Turn off column select Turn off multiple selection (code doesn't support it on delete). Update the xib for the class name change that happened as part of the prior commit. BUG=21892 TEST=window resize correctly, make default button fits it's text for all languages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26252

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -582 lines) Patch
M chrome/app/nibs/KeywordEditor.xib View 29 chunks +70 lines, -582 lines 0 comments Download
M chrome/browser/cocoa/keyword_editor_cocoa_controller.mm View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 3 months ago (2009-09-15 19:41:38 UTC) #1
Mark Mentovai
CL description: > The "make default" button Give more context. Which "make default" button? > ...
11 years, 3 months ago (2009-09-15 19:45:32 UTC) #2
TVL
updated
11 years, 3 months ago (2009-09-15 19:50:54 UTC) #3
Mark Mentovai
11 years, 3 months ago (2009-09-15 19:53:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698