Issue 206011: Make 'hidden' the default visibility for gcc. Add build option,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206011: Make 'hidden' the default visibility for gcc. Add build option, (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Make 'hidden' the default visibility for gcc. Add build option, visibility=[hidden|default], that controls visibility and make 'hidden' the default. Export a few variables that had been forgotten.

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -21 lines)			Patch
M	SConstruct	View	3 chunks	+9 lines, -1 line	1 comment	Download
M	include/v8.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-conversions.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	2 chunks	+15 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 3 months ago (2009-09-15 11:09:25 UTC) #2

LGTM

http://codereview.chromium.org/206011/diff/1/2
File SConstruct (right):

http://codereview.chromium.org/206011/diff/1/2#newcode119
Line 119: # Use visibility=default to disable this
.

Expand Messages | Collapse Messages