Issue 206009: linux: defend against "netscape" within plugin path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206009: linux: defend against "netscape" within plugin path (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: defend against "netscape" within plugin path Flash misbehaves if you load it from a path containing "netscape", so we try to avoid and warn the user if necessary. BUG=20758, 21900

Patch Set 2 : test flash player #

Patch Set 3 : test filename #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	webkit/glue/plugins/plugin_list_linux.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

http://codereview.chromium.org/206009/diff/1/2 File webkit/glue/plugins/plugin_list_linux.cc (right): http://codereview.chromium.org/206009/diff/1/2#newcode124 Line 124: if (orig_path.value().find(kNetscapeInPath) == std::string::npos) { I think we ...

11 years, 3 months ago (2009-09-15 04:58:07 UTC) #2

LGTM