Issue 206007: Uncouple the cert verifier when disconnecting to avoid a callback after a SSL...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206007: Uncouple the cert verifier when disconnecting to avoid a callback after a SSL... (Closed)

Created:
11 years, 3 months ago by hawk

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Uncouple the cert verifier when disconnecting to avoid a callback after a SSLClientSocketMac object has bee freed. BUG=21832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26236

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	net/socket/ssl_client_socket_mac.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. Thanks! http://codereview.chromium.org/206007/diff/1/2 File net/socket/ssl_client_socket_mac.cc (right): http://codereview.chromium.org/206007/diff/1/2#newcode434 Line 434: // Shut down anything that may ...

11 years, 3 months ago (2009-09-15 01:41:45 UTC) #2

hawk

11 years, 3 months ago (2009-09-15 21:40:29 UTC) #3

http://codereview.chromium.org/206007/diff/1/2
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/206007/diff/1/2#newcode434
Line 434: // Shut down anything that may call us back
On 2009/09/15 01:41:46, wtc wrote:
> Nit: add a period (.) at the end of the sentence.

Done.

Expand Messages | Collapse Messages